Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10

From: Nick Desaulniers
Date: Tue May 05 2020 - 19:37:02 EST


On Tue, May 5, 2020 at 4:22 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> On Tue, May 5, 2020 at 5:19 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > (Though as was mentioned, it's likely that FORTIFY_SOURCE isn't working
> > _at all_ under Clang, so I may still send a patch to depend on !clang
> > just to avoid surprises until it's fixed, but I haven't had time to
> > chase down a solution yet.)

Not good. If it's completely broken, turn it off, and we'll prioritize fixing.

> That might be the most coherent thing to do, at least so that people
> don't get some false sense of mitigation.

Do we have a better test for "this is working as intended" or not
other than excessive stack usage, since that doesn't repro for
clang-9?
--
Thanks,
~Nick Desaulniers