Re: [v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()

From: Markus Elfring
Date: Tue May 05 2020 - 16:18:01 EST


> What do you think about changing:
> "But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,.."
> to
â
> or
> "But when nfp_nsp_has_hwinfo_lookup fail,

I became curious about a related wording variant.

But when a call of the function âââ failed,


> NSP resource is not cleaned up and unlocked."

I find such information also nicer. (The abbreviation âNSPâ might need
another bit of clarification.)

I imagine there might be interests (eventually related to computer science)
to measure the corresponding object sizes because of a missed function call
and offer a more precise information in the commit message
(depending on the willingness to invest efforts in such a data determination).

Will such considerations become relevant for any subsequent
software development approaches?

Regards,
Markus