Re: [PATCH v2 0/4] kselftest: Extend vDSO tests

From: Arnd Bergmann
Date: Tue May 05 2020 - 10:50:37 EST


On Wed, Apr 29, 2020 at 1:34 PM Vincenzo Frascino
<vincenzo.frascino@xxxxxxx> wrote:
>
> This series extends the kselftests for the vDSO library making sure: that
> they compile correctly on non x86 platforms, that they can be cross
> compiled and introducing new tests that verify the correctness of the
> library.
>
> The so extended vDSO kselftests have been verified on all the platforms
> supported by the unified vDSO library [1].
>
> The only new patch that this series introduces is the first one, patch 2 and
> patch 3 have already been reviewed in past as part of other series [2] [3].
>
> [1] https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@xxxxxxx
> [2] https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@xxxxxxx
> [3] https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@xxxxxxx

Hi Vincenzo,

Not sure if you are aware of the recent bug report about clock_gettime64()
returning invalid times on some arm32 kernels:
https://github.com/raspberrypi/linux/issues/3579

Regardless of when that gets fixed or by whom, I wonder if kselftest should
also check for consistency, i.e. call both the vdso and the syscall version of
clock_gettime() and clock_gettime64() and check that the results are always
in sequence.

Arnd