Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues

From: Christoph Hellwig
Date: Tue May 05 2020 - 06:15:15 EST


> - for_each_sg_page(st->sgl, &sg_iter, st->nents, 0)
> + for_each_sg_page(st->sgl, &sg_iter, st->orig_nents, 0)

Would it make sense to also add a for_each_sgtable_page helper that
hides the use of orig_nents? To be used like:

for_each_sgtable_page(st, &sg_iter, 0) {

> + for_each_sg(sgt->sgl, sg, sgt->orig_nents, count) {

Same here, e.g.

for_each_sgtable_entry(sgt, sg, count) {

?