Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions

From: Kalle Valo
Date: Mon May 04 2020 - 05:50:57 EST


Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> In doing this, make brcmf_debugfs_add_entry() return void as no one was
> even paying attention to the return value.
>
> Cc: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
> Cc: Franky Lin <franky.lin@xxxxxxxxxxxx>
> Cc: Hante Meuleman <hante.meuleman@xxxxxxxxxxxx>
> Cc: Chi-Hsien Lin <chi-hsien.lin@xxxxxxxxxxx>
> Cc: Wright Feng <wright.feng@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "RafaÅ MiÅecki" <rafal@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: brcm80211-dev-list.pdl@xxxxxxxxxxxx
> Cc: brcm80211-dev-list@xxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions

--
https://patchwork.kernel.org/patch/11516617/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches