Re: [PATCH v4] checkpatch: add support to check 'Fixes:' tag format

From: Wang YanQing
Date: Sun May 03 2020 - 07:54:35 EST


On Sat, May 02, 2020 at 09:40:24PM +0200, Markus Elfring wrote:
>
>
> > + $diagnostics .= "Missing a pair of parentheses '()' or a pair of double quotation marks (\"\").\n";
>
> Can such a message trigger any more thoughts and development ideas?

No, I don't think so. '(" ... ")' is the minimum interface between analyser
(checkpatch) and commit id description (normal commit id and 'Fixes:' tag)
about the title, it is very difficult if not impossible to guess the title
boundary and whether it is the *REAL* title that folllow the SHA1 without
this precondition, and it is more difficult to do it when we need to support
title which across lines in the normal commit id description.

At last I really doubt the benefit it brings deserves the complexity and the
current diagnostics info is enough clear for most situation.

Thanks.