clk: keystone: Clarification for a return value check in _of_pll_clk_init()

From: Markus Elfring
Date: Sat May 02 2020 - 12:48:26 EST


Hello,

I have tried another small script out for the semantic patch language.
This source code analysis approach points out that the function âclk_register_pllâ
is called by the function â_of_pll_clk_initâ.
https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/clk/keystone/pll.c#L153
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/keystone/pll.c?id=690e2aba7beb1ef06352803bea41a68a3c695015#n153

A null pointer check is performed at this place.
The function âclk_register_pllâ (from the same source file) can eventually
return the pointer âERR_PTR(-ENOMEM)â.
Is there a need to take this special case also into account?

Regards,
Markus