Re: Remaining randconfig objtool warnings, linux-next-20200428

From: Peter Zijlstra
Date: Fri May 01 2020 - 13:16:43 EST


On Fri, May 01, 2020 at 01:41:30PM +0200, Arnd Bergmann wrote:
> disappears, and it also goes away if I disable inlining that function:

Yes, makes sense. The state objtool tracks is strictly per function.

And I suppose GCC-10 just changed around the inline heuristc a bit and
we got lucky.

> --- a/lib/locking-selftest.c
> +++ b/lib/locking-selftest.c
> @@ -1134,7 +1134,7 @@ static int testcase_successes;
> static int expected_testcase_failures;
> static int unexpected_testcase_failures;
>
> -static void dotest(void (*testcase_fn)(void), int expected, int lockclass_mask)
> +static noinline void dotest(void (*testcase_fn)(void), int expected,
> int lockclass_mask)
> {
> unsigned long saved_preempt_count = preempt_count();
>
> Arnd