Re: [RFC PATCH v9 6/9] media: tegra: Add Tegra210 Video input driver

[Dmitry Osipenko]

23.04.2020 19:50, Sowjanya Komatineni ÐÐÑÐÑ:
> 
> On 4/23/20 12:48 AM, Hans Verkuil wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 22/04/2020 08:18, Sowjanya Komatineni wrote:
>>> Tegra210 contains a powerful Video Input (VI) hardware controller
>>> which can support up to 6 MIPI CSI camera sensors.
>>>
>>> Each Tegra CSI port can be one-to-one mapped to VI channel and can
>>> capture from an external camera sensor connected to CSI or from
>>> built-in test pattern generator.
>>>
>>> Tegra210 supports built-in test pattern generator from CSI to VI.
>>>
>>> This patch adds a v4l2 capture driver with media interface for
>>> Tegra210 built-in CSI to VI test pattern generator.
>>>
>>> This patch includes TPG support only and all the video pipeline
>>> configuration happens through the video device node.
>>>
>>> Acked-by: Thierry Reding <treding@xxxxxxxxxx>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
>>> ---
>>> Â drivers/staging/media/KconfigÂÂÂÂÂÂÂÂÂ |ÂÂÂ 2 +
>>> Â drivers/staging/media/MakefileÂÂÂÂÂÂÂÂ |ÂÂÂ 1 +
>>> Â drivers/staging/media/tegra/KconfigÂÂÂ |ÂÂ 13 +
>>> Â drivers/staging/media/tegra/MakefileÂÂ |ÂÂÂ 8 +
>>> Â drivers/staging/media/tegra/TODOÂÂÂÂÂÂ |ÂÂ 10 +
>>> Â drivers/staging/media/tegra/common.hÂÂ |Â 262 ++++++++
>>> Â drivers/staging/media/tegra/csi.cÂÂÂÂÂ |Â 606 +++++++++++++++++
>>> Â drivers/staging/media/tegra/csi.hÂÂÂÂÂ |Â 149 +++++
>>> Â drivers/staging/media/tegra/tegra210.c |Â 709 ++++++++++++++++++++
>>> Â drivers/staging/media/tegra/tegra210.h |Â 190 ++++++
>>> Â drivers/staging/media/tegra/vi.cÂÂÂÂÂÂ | 1132
>>> ++++++++++++++++++++++++++++++++
>>> Â drivers/staging/media/tegra/vi.hÂÂÂÂÂÂ |ÂÂ 83 +++
>>> Â drivers/staging/media/tegra/video.cÂÂÂ |Â 153 +++++
>>> Â drivers/staging/media/tegra/video.hÂÂÂ |ÂÂ 34 +
>>> Â 14 files changed, 3352 insertions(+)
>>> Â create mode 100644 drivers/staging/media/tegra/Kconfig
>>> Â create mode 100644 drivers/staging/media/tegra/Makefile
>>> Â create mode 100644 drivers/staging/media/tegra/TODO
>>> Â create mode 100644 drivers/staging/media/tegra/common.h
>>> Â create mode 100644 drivers/staging/media/tegra/csi.c
>>> Â create mode 100644 drivers/staging/media/tegra/csi.h
>>> Â create mode 100644 drivers/staging/media/tegra/tegra210.c
>>> Â create mode 100644 drivers/staging/media/tegra/tegra210.h
>>> Â create mode 100644 drivers/staging/media/tegra/vi.c
>>> Â create mode 100644 drivers/staging/media/tegra/vi.h
>>> Â create mode 100644 drivers/staging/media/tegra/video.c
>>> Â create mode 100644 drivers/staging/media/tegra/video.h
>> With 'make menuconfig' I get this:
>>
>> scripts/kconfig/mconf Kconfig
>>
>> WARNING: unmet direct dependencies detected for TEGRA_HOST1X
>> ÂÂ Depends on [n]: HAS_IOMEM [=y] && (ARCH_TEGRA || ARM &&
>> COMPILE_TEST [=y])
>> ÂÂ Selected by [y]:
>> ÂÂ - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] &&
>> MEDIA_SUPPORT [=y] && (ARCH_TEGRA || COMPILE_TEST [=y])
>>
>> This is an x86_64 build with COMPILE_TEST set. I can provide my full
>> .config if you need it.
>>
>> CONFIG_TEGRA_HOST1X=y
>> CONFIG_VIDEO_TEGRA=y
>>
>> Regards,
>>
>> ÂÂÂÂÂÂÂÂ Hans
> 
> Hi Hans,
> 
> In v7, changed Kconfig to remove ARM. But looks like we should limit
> 
> TEGRA_HOST1X also limits compile to ARM only so running VIDEO_TEGRA on
> x86_64 shows above warning.
> 
> We should limit compile to ARM for CONFIG_VIDEO_TEGRA.
> 
> Will update CONFIG_VIDEO_TEGRA dependency to use ARM && COMPILE_TEST
> like I had in previous version. Sorry about this.
> 
> 
> Also, I see some changes went into latest linux-next staging media
> Kconfig, So, will have my patches on top of today's linux-next.

VIDEO_TEGRA should depend on TEGRA_HOST1X and not select it.

depends on (ARCH_TEGRA && TEGRA_HOST1X) || COMPILE_TEST