Re: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable

[David Miller]

From: Wong Vee Khee <vee.khee.wong@xxxxxxxxx>
Date: Thu, 23 Apr 2020 15:00:26 +0800

> From: "Chuah, Kim Tatt" <kim.tatt.chuah@xxxxxxxxx>
> 
> Add option in plat_stmmacenet_data struct to enable VLAN Filter Fail
> Queuing. This option allows packets that fail VLAN filter to be routed
> to a specific Rx queue when Receive All is also set.
> 
> When this option is enabled:
> - Enable VFFQ only when entering promiscuous mode, because Receive All
>   will pass up all rx packets that failed address filtering (similar to
>   promiscuous mode).
> - VLAN-promiscuous mode is never entered to allow rx packet to fail VLAN
>   filters and get routed to selected VFFQ Rx queue.
> 
> Reviewed-by: Voon Weifeng <weifeng.voon@xxxxxxxxx>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>
> Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@xxxxxxxxx>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>

Why would you be setting this with a platform attribute?  Even if the
capability exists, wouldn't you want the user to be able to choose
to opt out?