Re: [PATCH 2/3] dt-bindings: regulator: Add document bindings for max77826

[Iskren Chernev]

On 4/20/20 11:55 PM, Rob Herring wrote:
> On Mon, Apr 13, 2020 at 07:44:39PM +0300, Iskren Chernev wrote:
>> +ÂÂÂ patternProperties:
>> +ÂÂÂÂÂ "^LDO([1-9]|1[0-5])$":
>> +ÂÂÂÂÂÂÂ type: object
>> +ÂÂÂÂÂÂÂ allOf:
>> +ÂÂÂÂÂÂÂÂÂ - $ref: regulator.yaml#
>> +
>> +ÂÂÂÂÂ "^BUCK|BUCKBOOST$":
>> +ÂÂÂÂÂÂÂ type: object
>> +ÂÂÂÂÂÂÂ allOf:
>> +ÂÂÂÂÂÂÂÂÂ - $ref: regulator.yaml#
>> +
>> +ÂÂÂÂÂ additionalProperties: false
>
> You are defining a property called 'additionalProperties'. This one
> should be dropped because additionalProperties doesn't work with a $ref.
>

I got the idea from mps,mpq7920.yaml. It has additionalProperties in the
exact same places that I do. Also bd718(28|37|47).yaml seem to use
additionalProperties inside patternProperties. Shall I modify it as well?

I couldn't find the core schema for this yaml:
http://devicetree.org/meta-schemas/core.yaml (gives 404). Is there a way
to verify the validity of the yaml?

Also, this patch is already merged in linux-next. I guess I shall submit
a new patch with the fixes standalone?