RE: [PATCH 4/4] firmware: imx: scu-pd: add more cm4 resources

[Aisheng Dong]

> From: Peng Fan <peng.fan@xxxxxxx>
> Sent: Thursday, April 23, 2020 3:00 PM
> 
> Add more cm4 resources, then linux could use cm4's i2c/lpuart and could kick
> cm4 core.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>  drivers/firmware/imx/scu-pd.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
> index 7b43bd63cc1e..2fa86be2027a 100644
> --- a/drivers/firmware/imx/scu-pd.c
> +++ b/drivers/firmware/imx/scu-pd.c
> @@ -170,6 +170,16 @@ static const struct imx_sc_pd_range
> imx8qxp_scu_pd_ranges[] = {
>  	/* CM40 SS */
>  	{ "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, false, 0 },
>  	{ "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, false, 0 },
> +	{ "cm40_pid", IMX_SC_R_M4_0_PID0, 5, true, 0},
> +	{ "cm40_mu1a", IMX_SC_R_M4_0_MU_1A, 1, false, 0},
> +	{ "cm40_lpuart", IMX_SC_R_M4_0_UART, 1, false, 0},

For consistency,
s/cm40_pid/cm40-pid
s/cm40_mu1a/cm40-mu-a1
s/cm40_lpuart/cm40-lpuart

This also applies for the following part.

besides that, you can add my tag:
Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx>

Regards
Aisheng
	A
> +
> +	/* CM41 SS */
> +	{ "cm41_i2c", IMX_SC_R_M4_1_I2C, 1, false, 0 },
> +	{ "cm41_intmux", IMX_SC_R_M4_1_INTMUX, 1, false, 0 },
> +	{ "cm41_pid", IMX_SC_R_M4_1_PID0, 5, true, 0},
> +	{ "cm41_mu1a", IMX_SC_R_M4_1_MU_1A, 1, false, 0},
> +	{ "cm41_lpuart", IMX_SC_R_M4_1_UART, 1, false, 0},
>  };


> 
>  static const struct imx_sc_pd_soc imx8qxp_scu_pd = {
> --
> 2.16.4