Re: [PATCH v3] arm64: dts: meson: S922X: extend cpu opp-points

From: Neil Armstrong
Date: Thu Apr 23 2020 - 03:40:12 EST


On 23/04/2020 01:39, Tim Lewis wrote:
> HardKernel supports overclock through the addition to extra opp points
> in their official kernel sources for odroid-n2 [1]. Christian tested
> on other S922X devices with "no obvious issues". Neil thinks dvfs and
> thermal managementis can keep other S922X devices safe.
--------------/\
management

>
> [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> Tested-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
> Signed-off-by: Tim Lewis <elatllat@xxxxxxxxx>
>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
> 1 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> index 046cc332d..1e5d0ee5d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> @@ -65,6 +65,11 @@
> opp-hz = /bits/ 64 <1896000000>;
> opp-microvolt = <981000>;
> };
> +
> + opp-1992000000 {
> + opp-hz = /bits/ 64 <1992000000>;
> + opp-microvolt = <1001000>;
> + };
> };
>
> cpub_opp_table_1: opp-table-1 {
> @@ -120,5 +125,15 @@
> opp-hz = /bits/ 64 <1704000000>;
> opp-microvolt = <891000>;
> };
> +
> + opp-1800000000 {
> + opp-hz = /bits/ 64 <1800000000>;
> + opp-microvolt = <981000>;
> + };
> +
> + opp-1908000000 {
> + opp-hz = /bits/ 64 <1908000000>;
> + opp-microvolt = <1022000>;
> + };
> };
> };
>

The patch is well formed but I can only test on Odroid-N2.

Anyway, Christian did a test other S922X boxes and it doesn't crash.

Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

Neil