Re: [PATCH v2] net: ethernet: ixp4xx: Add error handling inixp4xx_eth_probe()

From: Tang Bin
Date: Wed Apr 22 2020 - 21:48:02 EST


Hi, Jackub:

On 2020/4/23 8:21, Jakub Kicinski wrote:
On Wed, 22 Apr 2020 09:09:22 +0800 Tang Bin wrote:
The function ixp4xx_eth_probe() does not perform sufficient error
checking after executing devm_ioremap_resource(), which can result
in crashes if a critical error path is encountered.

Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")

No extra lines, between the tags, though, please.

Got it, thanks for your guidance, I'll fix it and send v3 for you.

Thanks,

Tang Bin


Signed-off-by: Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>