Re: [PATCH v1 5/6] rcu: rename kfree_call_rcu()/__kfree_rcu()

From: Paul E. McKenney
Date: Wed Apr 22 2020 - 19:16:44 EST


On Wed, Apr 22, 2020 at 07:03:22PM -0400, Joel Fernandes wrote:
> On Tue, Apr 21, 2020 at 02:03:58PM +0200, Uladzislau Rezki wrote:
> > Hello, Andrew.
> >
> > > > > I based the kfree_rcu shrinker patches on an 'rcu/kfree' branch in my git
> > > > > tree: https://github.com/joelagnel/linux-kernel/tree/rcu/kfree
> > > > >
> > > > > For now I manually applied 5/6. All others applied cleanly.
> > > > >
> > > > > Updated the tree as I continue to review your patches.
> > > > >
> > >
> > > I'm not sure what's happening here - these patches aren't yet in
> > > linux-next.
> > >
> > Please have a look here, i explained in detail in my cover latter
> > what we would like to achieve: https://lkml.org/lkml/2020/3/23/242
> >
> > > A couple of thoughts:
> > >
> > > - Please cc linux-mm@xxxxxxxxx on this patchset and anything else
> > > which impacts MM.
> > >
> > OK. I thought that is related to RCU, therefore i did not want to
> > spam, but i included you :) Next time we will keep linux-mm@xxxxxxxxx
> > in a loop. Sorry for that.
>
> Sorry from my side as well. Will keep linux-mm in the loop henceforth.

I must confess that it came as a bit of a surprise to me as well.

But what is life without a surprise or two along the way? ;-)

Thanx, Paul

> thanks,
>
> - Joel
>
>
> >
> > >
> > > - It's a bit strange to create new infrastructure which has but a
> > > single call site. Please tell us much more about "there was also
> > > request/interest so there will be new comers" to set minds at ease.
> > >
> > > Who/where are these possible new callsites and when can we expect to
> > > see that code?
> > >
> > https://lkml.org/lkml/2020/3/23/242 here i wrote motivation. Please
> > check it. If you have some questions please ask.
> >
> > --
> > Vlad Rezki