RE: [PATCH v2 1/3] scsi: ufs: add write booster feature support

From: Avri Altman
Date: Wed Apr 22 2020 - 06:35:40 EST


> + /* Enable Write Booster if we have scaled up else disable it */
> + if (!ret) {
> + up_write(&hba->clk_scaling_lock);
> + ufshcd_wb_ctrl(hba, scale_up);
> + down_write(&hba->clk_scaling_lock);
> + }
Maybe add "goto out_unprepare" if ufshcd_scale_gear() in the clause above,
Instead of checking !ret, to follow the function flow.

Thanks,
Avri