Re: [PATCH 01/10] mm/page-flags: introduce PageHighMemZone()

[Joonsoo Kim]

2020ë 4ì 22ì (ì) ìì 10:02, Roman Gushchin <guro@xxxxxx>ëì ìì:
>
> On Tue, Apr 21, 2020 at 02:00:05AM -0700, Christoph Hellwig wrote:
> > I don't think the names are very good.  I'd keep PageHighMem for the
> > existing highmem zone, and add something like PageDirectMapped or
> > similar for ay page that has a valid direct mapping address.  This will
> > also come in handy if we plan to go ahead with the xpfo work.
> >
>
> I agree. It also looks like the only remaining place with PageHighMem()
> is using "if (!PageHighMem(page))", so "if (PageDirectlyMapped(page))" would be
> even better.

As mentioned in previous reply to Christoph, I will change the name after
everything is settle down.

> Joonsoo, the series in general looks very good to me. Please, feel free
> to add "Acked-by: Roman Gushchin <guro@xxxxxx>".

Thanks for reviewing this!

Thanks.