Re: [PATCH v2] media: uvcvideo: read bulk URBs after maxPayloadSize

From: kbuild test robot
Date: Wed Apr 22 2020 - 02:17:58 EST


Hi Julian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.7-rc2 next-20200421]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Julian-Meyer/media-uvcvideo-read-bulk-URBs-after-maxPayloadSize/20200421-225554
base: git://linuxtv.org/media_tree.git master
config: arm-davinci_all_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

drivers/media/usb/uvc/uvc_video.c: In function 'uvc_video_decode_bulk':
>> drivers/media/usb/uvc/uvc_video.c:1484:3: error: expected expression before '}' token
1484 | }
| ^
>> drivers/media/usb/uvc/uvc_video.c:1484:3: warning: 'return' with a value, in function returning void [-Wreturn-type]
drivers/media/usb/uvc/uvc_video.c:1458:13: note: declared here
1458 | static void uvc_video_decode_bulk(struct uvc_urb *uvc_urb,
| ^~~~~~~~~~~~~~~~~~~~~

vim +1484 drivers/media/usb/uvc/uvc_video.c

1457
1458 static void uvc_video_decode_bulk(struct uvc_urb *uvc_urb,
1459 struct uvc_buffer *buf, struct uvc_buffer *meta_buf)
1460 {
1461 struct urb *urb = uvc_urb->urb;
1462 struct uvc_streaming *stream = uvc_urb->stream;
1463 u8 *mem;
1464 int len;
1465 int len_processed;
1466
1467 /*
1468 * Ignore ZLPs if they're not part of a frame, otherwise process them
1469 * to trigger the end of payload detection.
1470 */
1471 if (urb->actual_length == 0 && stream->bulk.header_size == 0)
1472 return;
1473
1474 mem = urb->transfer_buffer;
1475 len = urb->actual_length;
1476
1477 while (len > 0) {
1478 len_processed = uvc_video_decode_bulk_single(stream, buf,
1479 meta_buf, uvc_urb, &mem, &len);
1480
1481 // if we don't process anything, we break out of the decode loop
1482 if (len_processed == 0) {
1483 return
> 1484 }
1485 }
1486 }
1487

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip