Re: [PATCH 1/4] loop: Refactor size calculation.

From: Martijn Coenen
Date: Tue Apr 21 2020 - 07:48:16 EST


On Mon, Apr 20, 2020 at 3:22 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> How about using the SECTOR_SHIFT constant instead of "9"?

Ack, will do.

> Please also change the "kill_bdev should have truncated all the pages"
> comment into something like "return -EAGAIN if any pages have been
> dirtied after kill_bdev() returned".

Sure - would you prefer this to be in a separate change?

Thanks,
Martijn

>
> Thanks,
>
> Bart.