Re: [PATCH 2/2] sched: Extract the task putting code from pick_next_task()

From: Steven Rostedt
Date: Mon Apr 20 2020 - 22:23:24 EST


On Tue, 21 Apr 2020 01:13:55 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > The 'finish' thing isn't too far from the truth; it's the last thing we
> > need to do with the prev task (in terms of sched bookkeeping, I mean) -
> > and in Chen's defence ISTR Peter suggested that name.
> >
> > Seeing as it's a "supercharged" put_prev_task(), I could live with the
> > marginally shorter "put_prev_task_balance()".
>
> What Valentin said; it's the last put we do before picking a new task.
> Also, I don't like long names. That said, I'm open to short and
> appropriate suggestions.

I wont bikeshed this too much.

Is the "finish" more appropriate with the other use cases that are
coming. I do like that "put_prev_task_balance()" too.

-- Steve