Re: [patch 00/15] x86/tlb: Unexport per-CPU tlbstate

From: Thomas Gleixner
Date: Mon Apr 20 2020 - 13:27:17 EST


Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
> Just looking over some exports at the end of the series (and thus
> ignoring bisection issues):
>
> - Is there any good reason to keep __flush_tlb_all inline vs moving it
> out of line and kill the flush_tlb_local and flush_tlb_global exports.
> Also there is just a single modular users in SVM, I wonder if there is
> any way to get rid of that one as well.

I'll have a look again.

> Also I think cpu_tlbstate itself could be marked static in tlb.c with
> a few more changes, I wonder if would be worth it?

Unfortunately it can't. We need it in the low level entry code due to
PTI and solving that would be a messy surgery.

Thanks,

tglx