Re: mfd: asic3: Add error checking return in asic3_mfd_probe()

From: Markus Elfring
Date: Mon Apr 20 2020 - 04:37:49 EST


>>> And remove the redundant 'ret = 0'.
>>
>> I propose to reconsider this interpretation of the source code here.
>> How do you think about to move the mentioned statement into an else branch
>> at the end?
>
> Could you please fix your mailer.

Would you like to help with increasing software development resources
according to corresponding open issues?

mailto:tangbin%40cmss.chinamobile.com?In-Reply-To=%3C20200419091923.5728-1-tangbin@xxxxxxxxxxxxxxxxxxxx%3E&Cc=lee.jones%40linaro.org%2Clinux-kernel%40vger.kernel.org%2Czhangshengju%40cmss.chinamobile.com&Subject=Re%3A%20%5BPATCH%5D%20mfd%3A%20asic3%3A%20Add%20error%20checking%20return%20in%20asic3_mfd_probe%28%29


Can any more clarification help also around the previous update suggestion
âmfd: asic3: Delete redundant variable definitionâ?
https://lore.kernel.org/lkml/20200403042020.17452-1-tangbin@xxxxxxxxxxxxxxxxxxxx/
https://lore.kernel.org/patchwork/patch/1219914/
https://lkml.org/lkml/2020/4/3/4

Regards,
Markus