Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

[Lee Jones]

On Fri, 17 Apr 2020, kgunda@xxxxxxxxxxxxxx wrote:

> On 2020-04-15 20:39, Rob Herring wrote:
> > On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote:
> > > Convert the qcom-wled bindings from .txt to .yaml format.
> > > Also replace PM8941 to WLED3 and PMI8998 to WLED4.
> > > 
> > > Signed-off-by: Kiran Gunda <kgunda@xxxxxxxxxxxxxx>
> > > Signed-off-by: Subbaraman Narayanamurthy <subbaram@xxxxxxxxxxxxxx>
> > > Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > > ---
> > >  .../bindings/leds/backlight/qcom-wled.txt          | 154
> > > ----------------
> > >  .../bindings/leds/backlight/qcom-wled.yaml         | 201
> > > +++++++++++++++++++++
> > >  2 files changed, 201 insertions(+), 154 deletions(-)
> > >  delete mode 100644
> > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > >  create mode 100644
> > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
[...]

> > > +        interrupt-names:
> > > +          items:
> > > +            - const: ovp
> > > +            - const: short
> > 
> > Move these 2 props to the main section adding a 'minItems: 1'. Then just
> > define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause.
> > 
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - label
> > 
> > Add:
> > 
> > additionalProperties: false
> > 
> > > +
> > > +examples:
> > > +  - |
> > > +    backlight@d800 {
> > > +        compatible = "qcom,pm8941-wled";
> > > +        reg = <0xd800 0x100>;
> > > +        label = "backlight";
> > > +
> > > +        qcom,cs-out;
> > > +        qcom,current-limit = <20>;
> > > +        qcom,current-boost-limit = <805>;
> > > +        qcom,switching-freq = <1600>;
> > > +        qcom,ovp = <29>;
> > > +        qcom,num-strings = <2>;
> > > +        qcom,enabled-strings = <0 1>;
> > > +     };
> Thanks for reviewing. I will submit the next revision with all the fixes.

Please trim your replies.

Also, if you agree with all of the review comments, there really is no
need to reply and/or thank the reviewer.  Simply submit a subsequent
set with a bumped version indicator.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog