Re: [PATCH 8/9] dax: fix empty-body warnings in bus.c

From: Christoph Hellwig
Date: Sun Apr 19 2020 - 04:15:56 EST


On Sat, Apr 18, 2020 at 11:41:10AM -0700, Randy Dunlap wrote:
> rc = -ENOMEM;
> } else
> - /* nothing to remove */;
> + do_empty(); /* nothing to remove */
> } else if (action == ID_REMOVE) {
> list_del(&dax_id->list);
> kfree(dax_id);
> } else
> - /* dax_id already added */;
> + do_empty(); /* dax_id already added */

This is just nasty. Please just always turn this bogus warning off
as the existing code is a perfectly readable idiom while the new code
is just nasty crap for no good reason at all.