Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c

From: Greg Kroah-Hartman
Date: Sun Apr 19 2020 - 02:04:12 EST


On Sun, Apr 19, 2020 at 08:02:47AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote:
> > Fix gcc empty-body warning when -Wextra is used:
> >
> > ../drivers/base/devcoredump.c:297:42: warning: suggest braces around empty body in an âifâ statement [-Wempty-body]
> > ../drivers/base/devcoredump.c:301:42: warning: suggest braces around empty body in an âifâ statement [-Wempty-body]
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > drivers/base/devcoredump.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > --- linux-next-20200417.orig/drivers/base/devcoredump.c
> > +++ linux-next-20200417/drivers/base/devcoredump.c
> > @@ -9,6 +9,7 @@
> > *
> > * Author: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > */
> > +#include <linux/kernel.h>
>
> Why the need for this .h file being added for reformatting the code?

Ah, the function you add, nevermind, need more coffee...