Re: [RESEND PATCH v3 0/3] Add Reset and Wakeup support for CCS811

From: Jonathan Cameron
Date: Sat Apr 18 2020 - 14:53:13 EST


On Wed, 15 Apr 2020 00:19:27 +0530
mani@xxxxxxxxxx wrote:

> From: Manivannan Sadhasivam <mani@xxxxxxxxxx>
>
> Hello,
>
> This patchset adds external reset and wakeup support for CCS811 VOC
> gas sensor. The nRESET and nWAKE pins available on the device are
> utilised to provide these functionalities.
>
> The patchset has been validated using CCS811 connected to STM32MP1 based
> board over I2C.
>
> While at it, the devicetree yaml binding and OF match table for this sensor
> are also added.
>
Looks good to me. I'd just like to give it a bit longer to allow dt
maintainers to take a look if they wish.

Thanks,

Jonathan

> Thanks,
> Mani
>
> Changes in v3:
>
> * Added ccs811_set_wake(false) to all error paths before calling it actually
> * Added Andy's reviewed-by tag
> * Added comment for reset procedure and dropped error print for gpio request
>
> Changes in v2:
>
> * Fixed DT binding schema and switched to dual license (GPL/BSD)
> * Returned actual error code from devm_gpiod_get_optional()
> * Dropped of.h include and of_match_ptr()
>
> Manivannan Sadhasivam (3):
> dt-bindings: iio: chemical: Add binding for CCS811 VOC sensor
> iio: chemical: Add support for external Reset and Wakeup in CCS811
> iio: chemical: Add OF match table for CCS811 VOC sensor
>
> .../bindings/iio/chemical/ams,ccs811.yaml | 51 ++++++++
> drivers/iio/chemical/ccs811.c | 112 ++++++++++++++++--
> 2 files changed, 152 insertions(+), 11 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
>