Re: [PATCH 1/5] habanalabs: Add INFO IOCTL opcode for time sync information

[Oded Gabbay]

On Sat, Apr 18, 2020 at 6:31 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> On 4/18/20 1:24 AM, Oded Gabbay wrote:
> > From: Tomer Tayar <ttayar@xxxxxxxxx>
> >
> > Add a new opcode to the INFO IOCTL that retrieves the device time
> > alongside the host time, to allow a user application that want to measure
> > device time together with host time (such as a profiler) to synchronize
> > these times.
> >
> > Signed-off-by: Tomer Tayar <ttayar@xxxxxxxxx>
> > Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
> > Signed-off-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
> > ---
> >  drivers/misc/habanalabs/goya/goya.c           | 10 +++-
> >  drivers/misc/habanalabs/goya/goyaP.h          |  1 +
> >  drivers/misc/habanalabs/habanalabs.h          |  2 +
> >  drivers/misc/habanalabs/habanalabs_ioctl.c    | 19 +++++++
> >  .../include/goya/asic_reg/goya_regs.h         |  1 +
> >  .../goya/asic_reg/psoc_timestamp_regs.h       | 56 +++++++++++++++++++
> >  include/uapi/misc/habanalabs.h                |  8 +++
> >  7 files changed, 96 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/misc/habanalabs/include/goya/asic_reg/psoc_timestamp_regs.h
>
> Hi,
> Not a comment about this patch per se, but ioctls (main number, 'H' in this case)
> should be documented in Documentation/userspace-api/ioctl/ioctl-number.rst.

I'll send a patch, thanks for telling me.
Oded

>
> thanks.
> --
> ~Randy
>