Re: [PATCH v1] i2c: busses: convert to devm_platform_get_and_ioremap_resource

From: Dejin Zheng
Date: Sat Apr 18 2020 - 00:07:15 EST


On Fri, Apr 17, 2020 at 11:46:33PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 16, 2020 at 3:19 AM Dejin Zheng <zhengdejin5@xxxxxxxxx> wrote:
> >
> > On Wed, Apr 15, 2020 at 12:21:58PM +0200, Wolfram Sang wrote:
> > > On Tue, Apr 14, 2020 at 09:48:27PM +0800, Dejin Zheng wrote:
> > > > use devm_platform_get_and_ioremap_resource() to simplify code, which
> > > > contains platform_get_resource() and devm_ioremap_resource(), it also
> > > > get the resource for use by the following code.
> > > >
> > > > Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>
> > >
> > > Applied to for-next, because it seems 'the new way' but...
> > >
> > > > - r_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > > - id->membase = devm_ioremap_resource(&pdev->dev, r_mem);
> > > > + id->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &r_mem);
> > >
> > > ... guys, do you really think this one line reduction improves
> > > readability? Oh well...
> > >
> > Wolfram, Thank you for accepting it. From my personal point of view,
> > as long as the direction is correct, even small improvements are
> > worth doing. Thanks again for your tolerance.
>
> Do you have plans to move on from janitor work to something serious?
>
Andy, I want to doïïbut I donïït know where to start, Could you give me
some suggestions? Thanks very much!

BR,
Dejin
> --
> With Best Regards,
> Andy Shevchenko