Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools

From: Christoph Hellwig
Date: Fri Apr 17 2020 - 03:10:04 EST



The subject should say something like "atomic unencrypted allocations.."
as many other atomic allocations are fine. Which brings up that with
the codebase in this patch we can't really support architectures that
require both an atomic pool for uncached remapping for just some devices
and unencrypted for others. We don't have such an archicture right now,
and I hope we don't grow one, but we probably need a little safeguard
with a BUILD_BUG_ON if both options are set. I can send an incremental
patch for that if that is ok with you.