Re: [PATCH 4/7] s390/module: Use s390_kernel_write() for relocations

From: Josh Poimboeuf
Date: Thu Apr 16 2020 - 08:07:49 EST


On Thu, Apr 16, 2020 at 10:56:02AM +0200, Miroslav Benes wrote:
> > + bool early = me->state == MODULE_STATE_UNFORMED;
> > +
> > + return __apply_relocate_add(sechdrs, strtab, symindex, relsec, me,
> > + early ? memcpy : s390_kernel_write);
>
> The compiler warns about
>
> arch/s390/kernel/module.c: In function 'apply_relocate_add':
> arch/s390/kernel/module.c:453:24: warning: pointer type mismatch in conditional expression
> early ? memcpy : s390_kernel_write);

Thanks, I'll get all that cleaned up.

I could have sworn I got a SUCCESS message from the kbuild bot. Does it
ignore warnings nowadays?

--
Josh