Re: [PATCH] ARM: pxa: ssp: Delete an error message in pxa_ssp_probe()

[Andy Shevchenko]

On Sat, Apr 4, 2020 at 5:03 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sat, 4 Apr 2020 15:50:10 +0200
> Subject: [PATCH] ARM: pxa: ssp: Delete an error message in pxa_ssp_probe()
>
> The function âplatform_get_irqâ can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.

...

>         ssp->irq = platform_get_irq(pdev, 0);
> -       if (ssp->irq < 0) {
> -               dev_err(dev, "no IRQ resource defined\n");
> +       if (ssp->irq < 0)
>                 return -ENODEV;
> -       }

At the same time we can unshadow the error code, i.e.
  return ssp->irq;


-- 
With Best Regards,
Andy Shevchenko