Re: [PATCH v2] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()

[Jason Gunthorpe]

On Wed, Mar 18, 2020 at 10:43:18PM +0200, Jarkko Sakkinen wrote:
> >  static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
> >  
> >  static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> > @@ -147,6 +149,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
> >  {
> >  	struct ibmvtpm_dev *ibmvtpm = dev_get_drvdata(&chip->dev);
> >  	int rc, sig;
> > +	bool retry = true;
> 
> Cosmetic: would be nice to have inits when possible in reverse
> Christmas tree order i.e.
> 
> 	struct ibmvtpm_dev *ibmvtpm = dev_get_drvdata(&chip->dev);
> 	bool retry = true;
> 	int rc, sig;
> 
> It is way more pleasing for the eye when you have to read the source
> code.

I thought only netdev insisted on that :O

Jason