Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq()

[Wolfram Sang]

Hi Uwe,

> Maybe add a comment for the next person who wonders about an error path
> without error message? Something like:
> 
> 	irq = platform_get_irq(pdev, 0);
> 	if (irq < 0)
> 		/*
> 		 * platform_get_irq() already issued an error message, so
> 		 * fail silently here.
> 		 */
> 		 return irq;

Hmm, too much boilerplate for my taste. I'd rather assume it will be
printed during the call.

> And to get some extra kudos mention the commit that modified
> platform_get_irq() to emit a message in the commit log.

Yes.

Kind regards,

   Wolfram

Attachment: signature.asc
Description: PGP signature