Re: [PATCH v2 rcu-dev 1/3] rcuperf: Add ability to increase object allocation size
From: Paul E. McKenney
Date: Tue Mar 17 2020 - 18:48:30 EST
On Tue, Mar 17, 2020 at 06:30:51PM -0400, Joel Fernandes wrote:
> On Tue, Mar 17, 2020 at 5:45 PM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
> >
> > On Tue, Mar 17, 2020 at 02:08:22PM -0700, Paul E. McKenney wrote:
> > > On Mon, Mar 16, 2020 at 12:32:26PM -0400, Joel Fernandes (Google) wrote:
> > > > This allows us to increase memory pressure dynamically using a new
> > > > rcuperf boot command line parameter called 'rcumult'.
> > > >
> > > > Signed-off-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
> > >
> > > Applied for testing and review, thank you!
> >
> > But testing did not go far:
> >
> > kernel/rcu/tree.c: In function âkfree_rcu_shrink_countâ:
> > kernel/rcu/tree.c:3120:16: warning: unused variable âflagsâ [-Wunused-variable]
> > unsigned long flags, count = 0;
>
> I fixed the warning already but did not resend since it was just the
> one unused variable warning. The patches are otherwise good to apply.
> Sorry, and I can resend it soon if you are not reapplying right now.
So remove "flags, " and all is well?
If so, I can just as easily fix that as take a new series. But next
time, please give a fella a warning. ;-)
Thanx, Paul