Re: [PATCH net 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset"

From: Florian Fainelli
Date: Mon Mar 16 2020 - 22:21:17 EST




On 3/16/2020 2:44 PM, Doug Berger wrote:
> This reverts commit 3a55402c93877d291b0a612d25edb03d1b4b93ac.
>
> This is not a good solution when connecting to an external switch
> that may not support the isolation of the TXC signal resulting in
> output driver contention on the pin.
>
> A different solution is necessary.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Did you want this to be tagged with:

Fixes: 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC reset")

so as to make it more explicit how the two commits relate to each other?

Thanks!
--
Florian