Re: [PATCH 2/3] clk: at91: allow setting PCKx parent via DT

From: kbuild test robot
Date: Mon Mar 16 2020 - 19:04:37 EST

Hi "MichaÅ,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next abelloni/rtc-next v5.6-rc6 next-20200312]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Micha-Miros-aw/clk-at91-support-configuring-PCKx-parent-via-DT/20200317-041729
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/clk/at91/at91sam9g45.c: In function 'at91sam9g45_pmc_setup':
>> drivers/clk/at91/at91sam9g45.c:118:20: error: too few arguments to function 'pmc_data_allocate'
118 | at91sam9g45_pmc = pmc_data_allocate(PMC_MAIN + 1,
| ^~~~~~~~~~~~~~~~~
In file included from drivers/clk/at91/at91sam9g45.c:8:
drivers/clk/at91/pmc.h:100:18: note: declared here
100 | struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem,
| ^~~~~~~~~~~~~~~~~
drivers/clk/at91/at91sam9g45.c:213:2: error: implicit declaration of function 'pmc_data_free' [-Werror=implicit-function-declaration]
213 | pmc_data_free(at91sam9g45_pmc);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/clk/at91/at91sam9n12.c: In function 'at91sam9n12_pmc_setup':
>> drivers/clk/at91/at91sam9n12.c:131:20: error: too few arguments to function 'pmc_data_allocate'
131 | at91sam9n12_pmc = pmc_data_allocate(PMC_MAIN + 1,
| ^~~~~~~~~~~~~~~~~
In file included from drivers/clk/at91/at91sam9n12.c:8:
drivers/clk/at91/pmc.h:100:18: note: declared here
100 | struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem,
| ^~~~~~~~~~~~~~~~~
drivers/clk/at91/at91sam9n12.c:231:2: error: implicit declaration of function 'pmc_data_free' [-Werror=implicit-function-declaration]
231 | pmc_data_free(at91sam9n12_pmc);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/clk/at91/sam9x60.c: In function 'sam9x60_pmc_setup':
>> drivers/clk/at91/sam9x60.c:185:16: error: too few arguments to function 'pmc_data_allocate'
185 | sam9x60_pmc = pmc_data_allocate(PMC_MAIN + 1,
| ^~~~~~~~~~~~~~~~~
In file included from drivers/clk/at91/sam9x60.c:8:
drivers/clk/at91/pmc.h:100:18: note: declared here
100 | struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem,
| ^~~~~~~~~~~~~~~~~
drivers/clk/at91/sam9x60.c:302:2: error: implicit declaration of function 'pmc_data_free' [-Werror=implicit-function-declaration]
302 | pmc_data_free(sam9x60_pmc);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/pmc_data_allocate +118 drivers/clk/at91/at91sam9g45.c

12dc8d3be9d86c Alexandre Belloni 2020-01-17 92
12dc8d3be9d86c Alexandre Belloni 2020-01-17 93 static void __init at91sam9g45_pmc_setup(struct device_node *np)
12dc8d3be9d86c Alexandre Belloni 2020-01-17 94 {
12dc8d3be9d86c Alexandre Belloni 2020-01-17 95 const char *slck_name, *mainxtal_name;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 96 struct pmc_data *at91sam9g45_pmc;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 97 const char *parent_names[6];
12dc8d3be9d86c Alexandre Belloni 2020-01-17 98 struct regmap *regmap;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 99 struct clk_hw *hw;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 100 int i;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 101 bool bypass;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 102
12dc8d3be9d86c Alexandre Belloni 2020-01-17 103 i = of_property_match_string(np, "clock-names", "slow_clk");
12dc8d3be9d86c Alexandre Belloni 2020-01-17 104 if (i < 0)
12dc8d3be9d86c Alexandre Belloni 2020-01-17 105 return;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 106
12dc8d3be9d86c Alexandre Belloni 2020-01-17 107 slck_name = of_clk_get_parent_name(np, i);
12dc8d3be9d86c Alexandre Belloni 2020-01-17 108
12dc8d3be9d86c Alexandre Belloni 2020-01-17 109 i = of_property_match_string(np, "clock-names", "main_xtal");
12dc8d3be9d86c Alexandre Belloni 2020-01-17 110 if (i < 0)
12dc8d3be9d86c Alexandre Belloni 2020-01-17 111 return;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 112 mainxtal_name = of_clk_get_parent_name(np, i);
12dc8d3be9d86c Alexandre Belloni 2020-01-17 113
12dc8d3be9d86c Alexandre Belloni 2020-01-17 114 regmap = syscon_node_to_regmap(np);
12dc8d3be9d86c Alexandre Belloni 2020-01-17 115 if (IS_ERR(regmap))
12dc8d3be9d86c Alexandre Belloni 2020-01-17 116 return;
12dc8d3be9d86c Alexandre Belloni 2020-01-17 117
12dc8d3be9d86c Alexandre Belloni 2020-01-17 @118 at91sam9g45_pmc = pmc_data_allocate(PMC_MAIN + 1,

:::::: The code at line 118 was first introduced by commit
:::::: 12dc8d3be9d86cccc35dcf32828d3a8e9d48e0d1 clk: at91: add at91sam9g45 pmc driver

:::::: TO: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
:::::: CC: Stephen Boyd <sboyd@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip