[PATCH net 0/3] ethtool: fail with error if request has unknown flags

From: Michal Kubecek
Date: Sun Mar 15 2020 - 13:17:42 EST


Jakub Kicinski pointed out that if unrecognized flags are set in netlink
header request, kernel shoud fail with an error rather than silently
ignore them so that we have more freedom in future flags semantics.

To help userspace with handling such errors, inform the client which
flags are supported by kernel. For that purpose, we need to allow
passing cookies as part of extack also in case of error (they can be
only passed on success now).

Michal Kubecek (3):
netlink: allow extack cookie also for error messages
netlink: add nl_set_extack_cookie_u32()
ethtool: reject unrecognized request flags

include/linux/netlink.h | 9 +++++++++
net/ethtool/netlink.c | 16 +++++++++++----
net/netlink/af_netlink.c | 43 ++++++++++++++++------------------------
3 files changed, 38 insertions(+), 30 deletions(-)

--
2.25.1