Re: [PATCH 0/2] gpio: mmio: introduce BGPIOF_NO_SET_ON_INPUT

From: Renà van Dorst
Date: Sun Mar 15 2020 - 08:54:36 EST


Quoting Chuanhong Guo <gch981213@xxxxxxxxx>:

Currently gpio-hog doesn't work on gpio-mt7621 driver. On further
debugging, I noticed that set/clear register on this controller
only works on output pins. We need to setup pin direction before
writing values in bgpio_dir_out for a correct gpio-hog behavior.
This patchset introduces a new flag BGPIOF_NO_SET_ON_INPUT for
these kind of controller and set this flag for gpio-mt7621.

Chuanhong Guo (2):
gpio: mmio: introduce BGPIOF_NO_SET_ON_INPUT
gpio: mt7621: add BGPIOF_NO_SET_ON_INPUT flag

drivers/gpio/gpio-mmio.c | 23 +++++++++++++++++++----
drivers/gpio/gpio-mt7621.c | 4 ++--
include/linux/gpio/driver.h | 1 +
3 files changed, 22 insertions(+), 6 deletions(-)

--
2.24.1
Thanks Chuanhong for debugging the problem!

With this patch gpio-hog works again.

For the series:

Tested-by: Renà van Dorst <opensource@xxxxxxxxxx>

Greats,

RenÃ