Re: [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset

[Chi-Hsien Lin]

On 03/13/2020 9:17, Soeren Moch wrote:
> On 13.03.20 12:03, Chi-Hsien Lin wrote:
> > On 12/16/2019 7:43, Heiko StÃbner wrote:
> > > Hi Soeren,
> > >
> > > Am Sonntag, 15. Dezember 2019, 22:24:10 CET schrieb Soeren Moch:
> > > > On 12.12.19 11:59, Soeren Moch wrote:
> > > > > On 12.12.19 10:42, Kalle Valo wrote:
> > > > > > Soeren Moch <smoch@xxxxxx> writes:
> > > > > >
> > > > > > > Add support for the BCM4359 chipset with SDIO interface and RSDB
> > > > > > > support
> > > > > > > to the brcmfmac wireless network driver in patches 1-7.
> > > > > > >
> > > > > > > Enhance devicetree of the RockPro64 arm64/rockchip board to use an
> > > > > > > AP6359SA based wifi/bt combo module with this chipset in patches
> > > > > > > 8-9.
> > > > > > >
> > > > > > >
> > > > > > > Chung-Hsien Hsu (1):
> > > > > > >  ÂÂ brcmfmac: set F2 blocksize and watermark for 4359
> > > > > > >
> > > > > > > Soeren Moch (5):
> > > > > > >  ÂÂ brcmfmac: fix rambase for 4359/9
> > > > > > >  ÂÂ brcmfmac: make errors when setting roaming parameters non-fatal
> > > > > > >  ÂÂ brcmfmac: add support for BCM4359 SDIO chipset
> > > > > > >  ÂÂ arm64: dts: rockchip: RockPro64: enable wifi module at sdio0
> > > > > > >  ÂÂ arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0
> > > > > > >
> > > > > > > Wright Feng (3):
> > > > > > >  ÂÂ brcmfmac: reset two D11 cores if chip has two D11 cores
> > > > > > >  ÂÂ brcmfmac: add RSDB condition when setting interface combinations
> > > > > > >  ÂÂ brcmfmac: not set mbss in vif if firmware does not support MBSS
> > > > > > >
> > > > > > >  Â .../boot/dts/rockchip/rk3399-rockpro64.dtsÂÂÂ | 50 +++++++++++---
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/bcmsdh.cÂÂÂÂÂ |Â 8 ++-
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/cfg80211.cÂÂÂ | 68
> > > > > > > +++++++++++++++----
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/chip.cÂÂÂÂÂÂÂ | 54 ++++++++++++++-
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/chip.hÂÂÂÂÂÂÂ |Â 1 +
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/pcie.cÂÂÂÂÂÂÂ |Â 2 +-
> > > > > > >  Â .../broadcom/brcm80211/brcmfmac/sdio.cÂÂÂÂÂÂÂ | 17 +++++
> > > > > > >  Â include/linux/mmc/sdio_ids.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 2 +
> > > > > > >  Â 8 files changed, 176 insertions(+), 26 deletions(-)
> > > > > > Just to make sure we are on the same page, I will apply patches
> > > > > > 1-7 to
> > > > > > wireless-drivers-next and patches 8-9 go to some other tree? And
> > > > > > there
> > > > > > are no dependencies between the brcmfmac patches and dts patches?
> > > > > Yes, this also is my understanding. I'm glad if you are fine with
> > > > > patches 1-7.
> > > > > Heiko will pick up patches 8-9 later for linux-rockchip independently.
> > > > > And if we need another round of review for patches 8-9, I think we
> > > > > don't
> > > > > need to bother linux-wireless with this.
> > > >
> > > > Heiko,
> > > >
> > > > is this OK for you when patches 1-7 are merged now in wireless-drivers,
> > > > and then I send a v3 for patches 8-9 only for you to merge in
> > > > linux-rockchip later? Or do you prefer a full v3 for the whole series
> > > > with only this pending clock name update in patch 9?
> > >
> > > Nope, merging 1-7 from this v2 and then getting a v3 with only the dts
> > > stuff is perfectly fine :-)
> >
> > Soeren,
> >
> > I suppose patch 1-7 from this serious are all good for merging. Is
> > that right? If so, could you please create a rebased V3?
> Chi-hsien,
>
> Thanks for asking, but these patches are already merged in
> torvalds/v5.6-rc1 as commits
> 1b8d2e0a9e42..2635853ce4ab
>
> So everything already fine with this.

Ahh... You're right. They're all good. Thanks a lot!!

> Thanks,
> Soeren
>
> > Regards,
> > Chi-hsien Lin
> >
> > > Heiko
> > >
> > >
> > > .