Re: [PATCH v2] powerpc/fsl-85xx: fix compile error

[Christophe Leroy]

Le 13/03/2020 Ã 19:17, çæè a ÃcritÂ:
> åääïChristophe Leroy <christophe.leroy@xxxxxx>
> åéææï2020-03-14 01:45:11
> æääïWANG Wenhu <wenhu.wang@xxxxxxxx>,Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>,Paul Mackerras <paulus@xxxxxxxxx>,Michael Ellerman <mpe@xxxxxxxxxxxxxx>,Richard Fontana <rfontana@xxxxxxxxxx>,Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>,Allison Randal <allison@xxxxxxxxxxx>,Thomas Gleixner <tglx@xxxxxxxxxxxxx>,linuxppc-dev@xxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx
> æéäïkernel@xxxxxxxx,trivial@xxxxxxxxxx
> äéïRe: [PATCH v2] powerpc/fsl-85xx: fix compile error>
> > Le 13/03/2020 Ã 18:19, WANG Wenhu a ÃcritÂ:
> > > Include "linux/of_address.h" to fix the compile error for
> > > mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
> > >
> > >     CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> > > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function âmpc85xx_l2ctlr_of_probeâ:
> > > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function âof_iomapâ; did you mean âpci_iomapâ? [-Werror=implicit-function-declaration]
> > >     l2ctlr = of_iomap(dev->dev.of_node, 0);
> > >              ^~~~~~~~
> > >              pci_iomap
> > > arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> > >     l2ctlr = of_iomap(dev->dev.of_node, 0);
> > >            ^
> > > cc1: all warnings being treated as errors
> > > scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
> > > make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
> > >
> > > Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> >
> > Shouldn't you Cc stable as well ?
> Pretty sure if it makes a difference(that I did not recognize).
> Does the inconsistency of Cc lead to a failure on classification
> or something else which may confuse you?

See 
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/process/submitting-patches.rst?h=v5.1.9#n299

> > > Signed-off-by: WANG Wenhu <wenhu.wang@xxxxxxxx>
> > > ---
> >
> > What's the difference between v1 and v2 ?
> The label field modification: "Fixed" -> "Fixes", which now is
> identified successfully. Really sorry for the fault on v1.

Ok. Usually people tell here (just below the ---) what is the difference 
between the different versions. It helps people understand what the 
changes are.

Christophe