Re: [PATCH] binderfs: port to new mount api

From: Christian Brauner
Date: Fri Mar 13 2020 - 08:57:02 EST


On Fri, Mar 13, 2020 at 01:55:53PM +0100, Christian Brauner wrote:
> On Thu, Mar 12, 2020 at 04:56:11PM -0700, Kees Cook wrote:
> > On Thu, Mar 12, 2020 at 10:24:20PM +0100, Christian Brauner wrote:
> > > It's time we port binderfs to the new mount api. We can make use of the
> > > new option parser, get nicer infrastructure and it will be easiert if we
> > > ever add any new mount options.
> > >
> > > This survives testing with the binderfs selftests:
> > >
> > > for i in `seq 1 1000`; do ./binderfs_test; done
> > >
> > > including the new stress tests I sent out for review today:
> > >
> > > [==========] Running 3 tests from 1 test cases.
> > > [ RUN ] global.binderfs_stress
> > > [ OK ] global.binderfs_stress
> > > [ RUN ] global.binderfs_test_privileged
> > > # Tests are not run as root. Skipping privileged tests
> > > [ OK ] global.binderfs_test_privileged
> >
> > I would use the XFAIL harness infrastructure for these kinds of skips.
>
> Hmyeah, will do.

For the selftests I sent out earlier that is.
This patch doesn't touch them. I just ran this patch on top of the
new stress test to show it passes.