Re: [PATCH v3 2/5] virtio_blk.c: Convert to use set_capacity_revalidate_and_notify

From: Christoph Hellwig
Date: Fri Mar 13 2020 - 07:10:24 EST


On Fri, Mar 13, 2020 at 05:30:06AM +0000, Balbir Singh wrote:
> block/genhd provides set_capacity_revalidate_and_notify() for sending RESIZE
> notifications via uevents.
>
> Signed-off-by: Balbir Singh <sblbir@xxxxxxxxxx>
> ---
> drivers/block/virtio_blk.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 0736248999b0..f9b1e70f1b31 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -388,18 +388,15 @@ static void virtblk_update_capacity(struct virtio_blk *vblk, bool resize)
> cap_str_10,
> cap_str_2);
>
> - set_capacity(vblk->disk, capacity);
> + set_capacity_revalidate_and_notify(vblk->disk, capacity, true);

Shouldn't the last argument be set to the resize argument passed to this
function?