Re: [PATCH] perf test: print if shell directory isn't present

[Jiri Olsa]

On Thu, Mar 12, 2020 at 05:56:02PM -0700, Ian Rogers wrote:
> If the shell test directory isn't present the exit code will be 255 but
> with no error messages printed. Add an error message.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> ---
>  tools/perf/tests/builtin-test.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 5f05db75cdd8..54d9516c9839 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -543,8 +543,11 @@ static int run_shell_tests(int argc, const char *argv[], int i, int width)
>  		return -1;
>  
>  	dir = opendir(st.dir);
> -	if (!dir)
> +	if (!dir) {
> +		pr_err("failed to open shell test directory: %s\n",
> +			st.dir);
>  		return -1;
> +	}
>  
>  	for_each_shell_test(dir, st.dir, ent) {
>  		int curr = i++;
> -- 
> 2.25.1.481.gfbce0eb801-goog
>