Re: [PATCH v7 13/48] Input: atmel_mxt_ts - add regulator control support

[Dmitry Osipenko]

12.02.2020 11:41, Jiada Wang ÐÐÑÐÑ:
> From: Nick Dyer <nick.dyer@xxxxxxxxxxx>
> 
> Allow the driver to optionally manage enabling/disable power to the touch
> controller itself. If the regulators are not present then use the deep
> sleep power mode instead.
> 
> For a correct power on sequence, it is required that we have control over
> the RESET line.

...
>  /* Firmware files */
>  #define MXT_FW_NAME		"maxtouch.fw"
> @@ -215,6 +217,9 @@ enum t100_type {
>  #define MXT_CRC_TIMEOUT		1000	/* msec */
>  #define MXT_FW_RESET_TIME	3000	/* msec */
>  #define MXT_FW_CHG_TIMEOUT	300	/* msec */
> +#define MXT_REGULATOR_DELAY	150	/* msec */
> +#define MXT_CHG_DELAY	        100	/* msec */
                                ^
Please use a tab instead of white-spaces. Same for MXT_COMMS_RETRIGEN in
the patch #4.