Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse

[Tony Fischetti]

Thanks for the feedback, y'all.
I will rename the device and add the signed-off field and resubmit.
Thanks again

On Tue, Mar 10, 2020 at 9:48 AM Filipe LaÃns <lains@xxxxxxxxxxxxx> wrote:
>
> On Wed, 2020-03-04 at 11:47 -0500, Tony Fischetti wrote:
> > A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> > where it disconnects and reconnects every minute--each time incrementing
> > the device number. This patch adds the device id of the device and
> > specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> > work properly.
> > ---
> >  drivers/hid/hid-ids.h    | 1 +
> >  drivers/hid/hid-quirks.c | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index 3a400ce603c4..9e1dfc714ea8 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -726,6 +726,7 @@
> >  #define USB_DEVICE_ID_LENOVO_X1_COVER        0x6085
> >  #define USB_DEVICE_ID_LENOVO_X1_TAB  0x60a3
> >  #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
> > +#define USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE        0x608d
>
> This ID is really ambiguous. Pixart makes the sensors for the big
> majority of devices. Isn't there any other identifier you could use? If
> there isn't, you could do USB_DEVICE_ID_LENOVO_MOUSE_608D.
>
> >  #define USB_VENDOR_ID_LG             0x1fd2
> >  #define USB_DEVICE_ID_LG_MULTITOUCH  0x0064
> > diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> > index 0e7b2d998395..247747d6d8cf 100644
> > --- a/drivers/hid/hid-quirks.c
> > +++ b/drivers/hid/hid-quirks.c
> > @@ -103,6 +103,7 @@ static const struct hid_device_id hid_quirks[] = {
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_PENSKETCH_M912), HID_QUIRK_MULTI_INPUT },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M406XE), HID_QUIRK_MULTI_INPUT },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2), HID_QUIRK_ALWAYS_POLL },
> > +     { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KEYBOARD_G710_PLUS), HID_QUIRK_NOGET },
>
> --
> Filipe LaÃns



-- 
--
Tony Fischetti
tony.fischetti@xxxxxxxxx
(718) 431-4597