Re: [PATCH v4 2/2] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

[Hans de Goede]

Hi,

On 3/12/20 12:42 PM, Borislav Petkov wrote:
> On Thu, Mar 12, 2020 at 12:31:39PM +0100, Hans de Goede wrote:
> > I will send out a v5 of my patch-set changing the first patch to
> > also fix the new issue the kbuild test robot has found. I'm going
> > to leave this patch as is. If you prefer replacing the second patch
> > in the set (this patch) with your solution then that is fine with me.
>
> Can we please slow down here, select the best solution, test it properly
> - yes, kexec file-based syscall whatever which uses the purgatory -

My version of this patch has already been tested this way. It is
Arvind's alternative version which has not been tested yet.

> and be
> done with it once and for all instead of quickly shooting out patchsets
> which keep breaking some randconfigs?

For v5 I have synced the list of disabled trace/sanitize options with
the one from drivers/firmware/efi/libstub/Makefile so v5 should catch
all known cases of things breaking with some special randconfigs.

Also I would like to point out that:

1. Things are already broken, my patch just exposes the brokenness
of some configs, it is not actually breaking things (well it breaks
the build, changing a silent brokenness into an obvious one).

2. I send out the first version of this patch on 7 October 2019, it
has not seen any reaction until now. So I'm sending out new versions
quickly now that this issue is finally getting some attention...

Regards,

Hans