Re: [RESEND][PATCH v8 1/6] usb: dwc3: Registering a role switch in the DRD code.

From: John Stultz
Date: Wed Mar 11 2020 - 15:54:40 EST


On Wed, Mar 11, 2020 at 12:44 PM John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> On Wed, Mar 11, 2020 at 12:17 PM Bryan O'Donoghue
> <bryan.odonoghue@xxxxxxxxxx> wrote:
> >
> > > +static int dwc3_usb_role_switch_set(struct device *dev, enum usb_role role)
> >
> > @bjorn found an API change that explodes this one.
> >
> > Fixed here: https://lkml.org/lkml/2020/3/11/1034
>
> Huh. I wonder why I don't see that causing trouble in my testing. :/
>
> Oddly, trying to use your patch results in build failures for me... Is
> the api change something in -next?

Ah. Ok, I found it: "usb: roles: Provide the switch drivers handle to
the switch in the API"

I'll add that to my patch series, retest and resubmit. Thanks for the heads up!
-john