Re: [PATCH v8 04/12] ir-rx51: Use 64-bit division macro

From: Sean Young
Date: Tue Mar 10 2020 - 22:11:28 EST


On Tue, Mar 10, 2020 at 06:41:13PM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_state.period's datatype
> to u64, prepare for this transition by using DIV_ROUND_CLOSEST_ULL to
> handle a 64-bit dividend.
>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Richard Fontana <rfontana@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> Cc: Allison Randal <allison@xxxxxxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx

Acked-by: Sean Young <sean@xxxxxxxx>

>
> Signed-off-by: Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> ---
> drivers/media/rc/ir-rx51.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c
> index 8574eda..9a5dfd7 100644
> --- a/drivers/media/rc/ir-rx51.c
> +++ b/drivers/media/rc/ir-rx51.c
> @@ -241,7 +241,8 @@ static int ir_rx51_probe(struct platform_device *dev)
> }
>
> /* Use default, in case userspace does not set the carrier */
> - ir_rx51.freq = DIV_ROUND_CLOSEST(pwm_get_period(pwm), NSEC_PER_SEC);
> + ir_rx51.freq = DIV_ROUND_CLOSEST_ULL(pwm_get_period(pwm),
> + NSEC_PER_SEC);
> pwm_put(pwm);
>
> hrtimer_init(&ir_rx51.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project