RE: [RESEND v6 07/13] spi: imx: remove ERR009165 workaround on i.mx6ul
From: Robin Gong
Date: Tue Mar 10 2020 - 05:31:46 EST
On 2020/03/10 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> On Tue, Mar 10, 2020 at 08:43:10AM +0000, Robin Gong wrote:
> > On 2020/03/10 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> > > On Tue, Mar 10, 2020 at 07:31:56PM +0800, Robin Gong wrote:
> > > > ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and
> > > > i.mx8m/8mm still need this errata. Please refer to nxp official
> > > > errata document from
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > > w.nx
> > >
> p.com%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cf73bfc11a68c4
> > >
> 2f5f6d308d7c4c96efa%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C
> > >
> 637194241755109112&sdata=xzIUP8qZkrlDXX0yjTcUNZB6zDrevTdHFg1o4
> > > PZZd8E%3D&reserved=0 .
> > > >
> > > > For removing workaround on those chips. Add new i.mx6ul type.
> > > >
> > > > Signed-off-by: Robin Gong <yibin.gong@xxxxxxx>
> > > > Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> > > > ---
> > > > drivers/spi/spi-imx.c | 50
> > > > +++++++++++++++++++++++++++++++++++++++++++++-----
> > > > 1 file changed, 45 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> > > > 842a86e..f7ee2ec 100644
> > > > --- a/drivers/spi/spi-imx.c
> > > > +++ b/drivers/spi/spi-imx.c
> > > > @@ -57,6 +57,7 @@ enum spi_imx_devtype {
> > > > IMX35_CSPI, /* CSPI on all i.mx except above */
> > > > IMX51_ECSPI, /* ECSPI on i.mx51 */
> > > > IMX53_ECSPI, /* ECSPI on i.mx53 and later */
> > > > + IMX6UL_ECSPI, /* ERR009165 fix from i.mx6ul */
> > > > };
> > > >
> > > > struct spi_imx_data;
> > > > @@ -75,6 +76,11 @@ struct spi_imx_devtype_data {
> > > > bool has_slavemode;
> > > > unsigned int fifo_size;
> > > > bool dynamic_burst;
> > > > + /*
> > > > + * ERR009165 fixed or not:
> > > > + *
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > > w.nx
> p.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01%7Cyi
> > >
> bin.gong%40nxp.com%7Cf73bfc11a68c42f5f6d308d7c4c96efa%7C686ea1d3bc
> > >
> 2b4c6fa92cd99c5c301635%7C0%7C1%7C637194241755109112&sdata=m
> > >
> uw4HL5nMDjREJwVd885Wrxka0moMaaZ%2BhJgsAgY3eo%3D&reserved=
> > > 0
> > > > + */
> > > > + bool tx_glitch_fixed;
> > > > enum spi_imx_devtype devtype;
> > > > };
> > > >
> > > > @@ -128,7 +134,8 @@ static inline int is_imx35_cspi(struct
> > > > spi_imx_data *d)
> > > >
> > > > static inline int is_imx51_ecspi(struct spi_imx_data *d) {
> > > > - return d->devtype_data->devtype == IMX51_ECSPI;
> > > > + return d->devtype_data->devtype == IMX51_ECSPI ||
> > > > + d->devtype_data->devtype == IMX6UL_ECSPI;
> > > > }
> > >
> > > Erm, no. A i.MX51 ECSPI is a i.MX51 ECSPI and not a i.MX6UL ECSPI.
> > > If you want to handle them equally somewhere then explicitly test
> > > for i.MX6ul *and*
> > > i.MX51 there.
> > But all i.mx6 chips including i.MX53 ECSPI are almost same as i.MX51 ECSPI,
> and ERR00915 is fixed from i.mx6ul....
>
> You introduce .devtype = IMX6UL_ECSPI in this series, so apparently it is *not*
> the same as IMX51_ECSPI, then please also don't introduce a function which
> claims they are the same.
Okay, I'll add is_imx6ul_ecspi explicitly.
>
> Sascha
>
> --
> Pengutronix e.K. |
> |
> Steuerwalder Str. 21 |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Ca10f3fdc
> 28084c1fe89a08d7c4d50531%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C637194291506592966&sdata=aqMqER0j0fVbAiKqM1tzBuEVlhiVcVL
> GnrSRhJvhDk8%3D&reserved=0 |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |