Re: [PATCH] staging: vt6656: Declare a few variables as __read_mostly

From: Quentin Deslandes
Date: Mon Mar 09 2020 - 05:32:17 EST


On Sat, Mar 07, 2020 at 09:29:06AM +0100, Oscar Carter wrote:
> On Sun, Mar 01, 2020 at 04:09:13PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Mar 01, 2020 at 02:17:01PM +0100, Oscar Carter wrote:
> > This is a USB driver, performance is always limited to the hardware, not
> > the CPU location of variables.
>
> Thank you for the explanation.
>
> >
> > Please always benchmark things to see if it actually makes sense to make
> > changes like this, before proposing them.
>
> I'm sorry.
>

I've been removed from CC list on Greg's answer, so I haven't seen the
explanation earlier and reviewed the patch the next day. I should have
know better, won't happen again.

Thank you,
Quentin